Fix a FileNotFound err with tmpDir in immediate tasks #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an immediate task is ran the api worker switches directory to a tmp directory inside the working directory. After the task is finished the tmp directory is deleted, but the api worker still thinks it is in the tmp directory thus causing future cwd to fail. This commit changes the pulpcore code to chdir back after finishing the task.
ggainey
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an immediate task is ran the api worker switches directory to a tmp directory inside the working directory. After the task is finished the tmp directory is deleted, but the api worker still thinks it is in the tmp directory thus causing future cwd to fail. This commit changes the pulpcore code to chdir back after finishing the task.